incentive/psopeeps-newserv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

enforce 6x command size limit

Browse Source
This commit is contained in:
Martin Michelsen
2023-10-07 18:22:58 -07:00
parent d5cc91a9bf
commit 07b1e9cde3
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TODO.md
-1
View File
@@ -4,7 +4,6 @@
- Implement server-side drops on non-BB game versions - Implement server-side drops on non-BB game versions
- Find a way to silence audio in RunDOL.s - Find a way to silence audio in RunDOL.s
- Implement private and overflow lobbies - Implement private and overflow lobbies
- Enforce client-side size limits (e.g. for 60/62 commands) on the server side as well
- Encapsulate BB server-side random state and make replays deterministic - Encapsulate BB server-side random state and make replays deterministic
- Implement character and inventory replacement for battle and challenge modes - Implement character and inventory replacement for battle and challenge modes
- Implement choice search - Implement choice search
src/ReceiveCommands.cc
+3
View File
@@ -2660,6 +2660,9 @@ static void on_61_98(shared_ptr<Client> c, uint16_t command, uint32_t flag, cons
static void on_6x_C9_CB(shared_ptr<Client> c, uint16_t command, uint32_t flag, const string& data) { static void on_6x_C9_CB(shared_ptr<Client> c, uint16_t command, uint32_t flag, const string& data) {
check_size_v(data.size(), 4, 0xFFFF); check_size_v(data.size(), 4, 0xFFFF);
if ((data.size() > 0x400) && (command != 0x6C) && (command != 0x6D)) {
throw runtime_error("non-extended game command data size is too large");
}
on_subcommand_multi(c, command, flag, data); on_subcommand_multi(c, command, flag, data);
} }