incentive/psopeeps-newserv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix out-of-bounds access in 6x46, etc.

Browse Source
This commit is contained in:
Martin Michelsen
2025-09-11 10:12:44 -07:00
parent 0b86ffb227
commit 55cbf6e20b
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ReceiveSubcommands.cc
+4 -1
View File
@@ -452,7 +452,10 @@ void forward_subcommand_with_entity_targets_transcode_t(shared_ptr<Client> c, Su
continue; continue;
} }
if (c->version() != lc->version()) { if (c->version() != lc->version()) {
CmdT out_cmd = cmd; // NOTE: We can't just do `CmdT out_cmd = cmd` here because cmd may not
// point to a full command; it is likely shorter than the full structure
CmdT out_cmd;
memcpy(&out_cmd, &cmd, msg.size);
out_cmd.header.subcommand = translate_subcommand_number(lc->version(), c->version(), cmd.header.subcommand); out_cmd.header.subcommand = translate_subcommand_number(lc->version(), c->version(), cmd.header.subcommand);
if (out_cmd.header.subcommand) { if (out_cmd.header.subcommand) {
size_t valid_targets = 0; size_t valid_targets = 0;