From 7db761f181eb0c0bea7c9a6ee92d8be38bc78ae0 Mon Sep 17 00:00:00 2001
From: Martin Michelsen <fuzziqersoftware+g@gmail.com>
Date: Wed, 6 Dec 2023 15:57:37 -0800
Subject: [PATCH]  fix attribute upgrade in Gallon's Shop

---
 src/ReceiveSubcommands.cc | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/ReceiveSubcommands.cc b/src/ReceiveSubcommands.cc
index 60800108..5241a133 100644
--- a/src/ReceiveSubcommands.cc
+++ b/src/ReceiveSubcommands.cc
@@ -2795,17 +2795,16 @@ static void on_upgrade_weapon_attribute_bb(shared_ptr<Client> c, uint8_t, uint8_
 
       size_t attribute_index = 0;
       for (size_t z = 6; z <= 10; z += 2) {
-        if (!(item.data1[z] & 0x80) && (item.data1[z] == cmd.attribute)) {
-          attribute_index = z;
-        } else if (item.data1[z] == 0) {
+        if ((item.data1[z] == 0) || (!(item.data1[z] & 0x80) && (item.data1[z] == cmd.attribute))) {
           attribute_index = z;
+          break;
         }
       }
       if (attribute_index == 0) {
         throw runtime_error("no available attribute slots");
       }
       item.data1[attribute_index] = cmd.attribute;
-      item.data1[attribute_index] += attribute_amount;
+      item.data1[attribute_index + 1] += attribute_amount;
 
       send_destroy_item(c, item.id, 1);
       send_create_inventory_item(c, item);