From aa19fd347ea94bbac7fdb5a5c7827e281781d745 Mon Sep 17 00:00:00 2001 From: Martin Michelsen Date: Sat, 17 Dec 2022 10:31:55 -0800 Subject: [PATCH] add some TODOs --- src/CatSession.cc | 2 ++ src/ReplaySession.cc | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/CatSession.cc b/src/CatSession.cc index 3869506c..d05fd4bc 100644 --- a/src/CatSession.cc +++ b/src/CatSession.cc @@ -105,6 +105,8 @@ void CatSession::on_channel_input( } } + // TODO: Use the iovec form of print_data here instead of + // prepend_command_header (which copies the string) string full_cmd = prepend_command_header( this->channel.version, this->channel.crypt_in.get(), command, flag, data); print_data(stdout, full_cmd, 0, nullptr, PrintDataFlags::PRINT_ASCII | PrintDataFlags::OFFSET_16_BITS); diff --git a/src/ReplaySession.cc b/src/ReplaySession.cc index 1fba94df..ea5889bf 100644 --- a/src/ReplaySession.cc +++ b/src/ReplaySession.cc @@ -593,6 +593,8 @@ void ReplaySession::dispatch_on_error(Channel& ch, short events) { void ReplaySession::on_command_received( shared_ptr c, uint16_t command, uint32_t flag, string& data) { + // TODO: Use the iovec form of print_data here instead of + // prepend_command_header (which copies the string) string full_command = prepend_command_header( c->version, c->channel.crypt_in.get(), command, flag, data); this->commands_received++;