update comment on send_lobby_list

src/SendCommands.cc

@@ -1751,9 +1751,12 @@ void send_quest_categories_menu(
 }
 
 void send_lobby_list(shared_ptr<Client> c) {
-  // This command appears to be deprecated, as PSO expects it to be exactly how
+  // DC v1 expects 10 lobbies in this list; DC v2 and later accept a variable
-  // this server sends it, and does not react if it's different, except by
+  // number, but other parts of the code expect there to always be 15 lobbies.
-  // changing the lobby IDs.
+  // Furthermore, there are only 16 entries in the array in TProtocol and the
+  // writes aren't bounds-checked, so the 83 command could overwrite later
+  // parts of TProtocol if more than 16 entries are sent. (On Episode 3, there
+  // are 21 entries instead.)
 
   auto s = c->require_server_state();
   vector<S_LobbyListEntry_83> entries;

system/client-functions/DrawDistance/DrawDistance.59NL.patch.s

@@ -82,7 +82,7 @@ patch_func_3:
   mov       dword [0x00518803], 0x90909090
   ret
 
-# TODO: Which objects this affects?
+# TOComputerMachine01
 patch_func_4:
   pop       ecx
   push      7
@@ -103,7 +103,7 @@ patch_code_end4:
   push      ecx
   jmp       write_call_func
 
-# TODO: This one too?
+# TObjCamera
 patch_func_5:
   pop       ecx
   push      6