From ef53a3b269aed53604655b275a45fa3e4384684e Mon Sep 17 00:00:00 2001
From: Martin Michelsen <fuzziqersoftware+g@gmail.com>
Date: Mon, 24 Feb 2025 10:20:20 -0800
Subject: [PATCH] fix signed comparison

---
 src/RareItemSet.cc | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/RareItemSet.cc b/src/RareItemSet.cc
index 02d03a79..c8616ecf 100644
--- a/src/RareItemSet.cc
+++ b/src/RareItemSet.cc
@@ -224,13 +224,14 @@ RareItemSet::SpecCollection RareItemSet::ParsedRELData::as_collection() const {
     ret.rt_index_to_specs[z].emplace_back(drop);
   }
   for (const auto& drop : this->box_rares) {
-    if (drop.drop.data.empty()) {
+    if ((drop.area_norm_plus_1 == 0) || drop.drop.data.empty()) {
       continue;
     }
-    if (drop.area_norm_plus_1 - 1 >= ret.box_area_norm_to_specs.size()) {
-      ret.box_area_norm_to_specs.resize(drop.area_norm_plus_1);
+    uint8_t area_norm = drop.area_norm_plus_1 - 1;
+    if (area_norm >= ret.box_area_norm_to_specs.size()) {
+      ret.box_area_norm_to_specs.resize(area_norm + 1);
     }
-    ret.box_area_norm_to_specs[drop.area_norm_plus_1 - 1].emplace_back(drop.drop);
+    ret.box_area_norm_to_specs[area_norm].emplace_back(drop.drop);
   }
   return ret;
 }