From f1f5c1036af6de06a5875b77ab423f4a55fa51d9 Mon Sep 17 00:00:00 2001 From: Martin Michelsen Date: Sun, 16 Nov 2025 00:05:47 -0800 Subject: [PATCH] fix invalid range check --- src/QuestScript.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/QuestScript.cc b/src/QuestScript.cc index e339d76d..df660686 100644 --- a/src/QuestScript.cc +++ b/src/QuestScript.cc @@ -3005,7 +3005,7 @@ CreateItemMaskEntry::operator QuestMetadata::CreateItemMask() const { // 1MMMmmm (m = min, M = max) uint32_t min = v % 1000; uint32_t max = (v / 1000) % 1000; - if (min > 0xFF || max > 0xFF | min > max) { + if ((min > 0xFF) || (max > 0xFF) || (min > max)) { throw std::runtime_error(std::format("invalid range spec {} (0x{:X})", v, v)); } ret.data1_ranges[z] = Range{.min = static_cast(min), .max = static_cast(max)};