fix some struct notes

TODO.md

@@ -22,6 +22,7 @@
     - Send 6xB4x4C, etc. commands when joining a spectator team - maybe this makes it load faster?
     - Figure out why spectators crash during replays sometimes
     - Spectator teams sometimes stop receiving commands during live battles?
+    - It may be possible to send spectators back to the waiting room after a non-tournament battle by sending 6xB4x05 with environment 0x19, then 6xB4x3B again; try this
 
 ## PSOBB
 

src/CommandFormats.hh

@@ -6224,8 +6224,8 @@ struct G_Unknown_GC_Ep3_6xB3x3A_CAx3A {
 // battle. A 6xB4x05 and 6xB6x41 command shouldhave been sent before this, to
 // set the map state that should appear for the new spectator.
 
-struct G_LoadCurrentEnvironment_GC_Ep3_6xB4x05 {
+struct G_LoadCurrentEnvironment_GC_Ep3_6xB4x3B {
-  G_CardBattleCommandHeader header = {0xB4, sizeof(G_LoadCurrentEnvironment_GC_Ep3_6xB4x05) / 4, 0, 0x3B, 0, 0, 0};
+  G_CardBattleCommandHeader header = {0xB4, sizeof(G_LoadCurrentEnvironment_GC_Ep3_6xB4x3B) / 4, 0, 0x3B, 0, 0, 0};
   parray<uint8_t, 4> unused;
 } __packed__;
 

src/Episode3/DataIndexes.hh

@@ -995,7 +995,7 @@ struct MapDefinition { // .mnmd format; also the format of (decompressed) quests
   // camera zones are evaluated continuously during the battle, and the camera
   // will move to focus on the part of the field where the SCs/FCs are. (Or,
   // more accurately, where the corresponding entry in camera_zone_specs says
-  // to focus.) camera_zone_maps is indexed as [team_id][camera_zone_num][x][y];
+  // to focus.) camera_zone_maps is indexed as [team_id][camera_zone_num][y][x];
   // camera_zone_specs is indexed as [team_id][camera_zone_num]. Unused entries
   // (beyond num_camera_zones) in both arrays should be filled with FF bytes.
   /* 0118 */ parray<parray<parray<parray<uint8_t, 0x10>, 0x10>, 10>, 2> camera_zone_maps;
@@ -1099,9 +1099,8 @@ struct MapDefinition { // .mnmd format; also the format of (decompressed) quests
   // this map. Unused entries should be set to FFFF.
   /* 59B0 */ parray<be_uint16_t, 0x10> reward_card_ids;
 
-  // These fields appear to be used for the purpose of determining which cards
+  // These fields are used when determining which cards to drop after the battle
-  // to drop after the battle is complete. If either is negative, the player's
+  // is complete. If either is negative, the player's CLv is used instead.
-  // actual CLv is used instead.
   /* 59D0 */ be_int32_t win_level_override;
   /* 59D4 */ be_int32_t loss_level_override;
 
@@ -1114,7 +1113,7 @@ struct MapDefinition { // .mnmd format; also the format of (decompressed) quests
   // map_category specifies where the map should appear in the maps menu. If
   // this is 0, 1, or 2, the map appears in the Quest section; otherwise, it
   // appears in the Free Battle section instead. It's not known if this controls
-  // anything else.
+  // anything else, or what the difference is in behavior between 0, 1, and 2.
   /* 59DC */ uint8_t map_category;
 
   // This field determines block graphics to be used in the Cyber environment.

src/Episode3/Server.cc

@@ -295,7 +295,7 @@ void Server::send_commands_for_joining_spectator(Channel& c, bool is_trial) cons
     c.send(0xC9, 0x00, this->prepare_6xB4x1C_names_update());
     c.send(0xC9, 0x00, this->prepare_6xB4x50_trap_tile_locations());
     {
-      G_LoadCurrentEnvironment_GC_Ep3_6xB4x05 cmd_3B;
+      G_LoadCurrentEnvironment_GC_Ep3_6xB4x3B cmd_3B;
       c.send(0xC9, 0x00, &cmd_3B, sizeof(cmd_3B));
     }
   }